Skip to content

chore(phpstan): upgrade to be compatible with latest dependency updates#3835

Merged
SychO9 merged 11 commits into2.xfrom
sm/phpstan-upgrade
Jun 15, 2023
Merged

chore(phpstan): upgrade to be compatible with latest dependency updates#3835
SychO9 merged 11 commits into2.xfrom
sm/phpstan-upgrade

Conversation

@SychO9
Copy link
Member

@SychO9 SychO9 commented Jun 15, 2023

Changes proposed in this pull request:
This is one of two PRs to upgrade phpstan (and larastan in the process) to be compatible with the recent php and dependency upgrades.

Now that we have PHP 8.1 as a minimum, a subsequent PR will upgrade the level of analysis to 6+

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

SychO9 and others added 5 commits June 15, 2023 11:44
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 requested a review from a team as a code owner June 15, 2023 12:23
SychO9 added 4 commits June 15, 2023 13:29
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
# Conflicts:
#	php-packages/testing/src/integration/TestCase.php
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 marked this pull request as draft June 15, 2023 12:45
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 force-pushed the sm/phpstan-upgrade branch from e6b7ace to 70eb74a Compare June 15, 2023 16:37
@SychO9 SychO9 marked this pull request as ready for review June 15, 2023 16:48
@SychO9 SychO9 added this to the 2.0 milestone Jun 15, 2023
@SychO9 SychO9 changed the title chore(phpstan): upgrade to be compatible with latest dependency updates. chore(phpstan): upgrade to be compatible with latest dependency updates Jun 15, 2023
@SychO9 SychO9 added breaking-changes dependencies Pull requests that update a dependency file labels Jun 15, 2023
@SychO9 SychO9 merged commit 493ffa0 into 2.x Jun 15, 2023
@SychO9 SychO9 deleted the sm/phpstan-upgrade branch June 15, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-changes dependencies Pull requests that update a dependency file type/infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants