chore: corrected typos in routes comments#3840
Merged
SychO9 merged 1 commit intoflarum:2.xfrom Jun 24, 2023
JamesShaver:patch-1
Merged
chore: corrected typos in routes comments#3840SychO9 merged 1 commit intoflarum:2.xfrom JamesShaver:patch-1
SychO9 merged 1 commit intoflarum:2.xfrom
JamesShaver:patch-1
Conversation
Corrected typos in the comments
askvortsov1
approved these changes
Jun 23, 2023
Member
askvortsov1
left a comment
There was a problem hiding this comment.
Do we need all these comments? Feels like the code is fairly self explanatory
Contributor
Author
The code comments show up in IDEs, so I would say yes each method needs to be commented accurately. |
Contributor
|
If they were function definitions, sure. I don't oppose to any of these, though. |
SychO9
approved these changes
Jun 24, 2023
Member
SychO9
left a comment
There was a problem hiding this comment.
Thanks! I do agree with Sasha though, the code is readable enough not to need these comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected typos in the comments
Fixes #0000
Changes proposed in this pull request:
Reviewers should focus on:
Screenshot
QA
Necessity
Confirmed
composer test).Required changes: