Skip to content

feat: theming and extensibility improvements#3876

Merged
SychO9 merged 15 commits into2.xfrom
dev-theming-improvements
Oct 10, 2023
Merged

feat: theming and extensibility improvements#3876
SychO9 merged 15 commits into2.xfrom
dev-theming-improvements

Conversation

@SychO9
Copy link
Member

@SychO9 SychO9 commented Aug 29, 2023 •
edited
Loading

Changes proposed in this pull request:
Part of the roadmap, each commit has a separate PR. Changes are made one at a time for easier review/readability, feel free to review within the related PR (if you wish) even if it's marked as merged.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

SychO9 added 12 commits August 29, 2023 15:06
@SychO9
feat: make page structure customizable across different pages (#3867)
f70ed85 
* feat: create `PageStructure` component
* feat: apply to `DiscussionPage`
* feat: apply to `UserPage`
* feat: apply to `TagsPage`
* fix: adapt subscriptions ext
* chore: cleanup
@SychO9
chore: use grid & flexbox for the discussion list item (#3868)
61e4d8c 
* chore: rename `DiscussionPage-list` to `DiscussionListPane`
* chore: itemlistify `DiscussionListItem`
* chore: use flex and grid for `DiscussionListItem`
@SychO9
chore: use flexbox for App-header (#3869)
ea2514c 
* chore: use flex and grid for `App-header`
* chore: drop search floats
* fix: adapt admin styles
@SychO9
chore: use flexbox in dropdowns and SplitDropdown for subscriptions (#…
316f428 
…3874)

* chore: flexbox dropdown menu items
* chore: normalize subscriptions menu (use slit dropdown)
* chore: cleanup
@SychO9
chore: misc flexbox/grid changes (#3875)
0a2e1a4 
* chore: `TagsPage` to tsx
* chore: `TagsPage` flexbox/grid
* chore: `IndexPage-toolbar` flexbox
* chore: `UserCard` flexbox & itemlists
* fix: `Post` improve spacing logic
* chore: `Post` grid and proper spacing
* fix: avatar editor hover layer layout
* chore: `Button` flex
@SychO9
chore: normalize form semantics (#3877)
c4f54b9 
* chore: normalize fieldsets
* fix: `LinkButton` spacing
* chore: consistent form semantics
@SychO9
fix: styling regressions (#3878)
18ba032 
* fix: post spacing goes off in other pages
* fix: regression
@SychO9
feat: extract reusable components from NotificationsDropdown (#3879)
8b5e5ff
@SychO9
feat: extensible global notices (#3880)
ea21e65 
* fix: js error on null item list
* feat: extensible global notices
@SychO9
chore: housekeeping (#3881)
d24f29c 
* chore: use CSS variables where still not using
* chore: cleanup suspension modal
* chore: cleanup post flag
* fix: badge vertical align
* chore: use CSS variables for custom coloring
* chore: `icon` helper to `Icon` component
* chore: `avatar` helper to `Avatar` component
* fix: chunk loading fails on admin frontend
* chore: format
@SychO9
feat: reusable UploadImageButton component (#3882)
f51cb94 
* chore: convert `UploadImageButton` to tsx
* feat: reusable `UploadImageButton` component
* feat: add `image-upload` setting type
@SychO9
feat: extensible default footer component (#3883)
06432c5
@SychO9 SychO9 changed the title Dev theming improvements feat: theming and extensibility improvements Sep 15, 2023
@SychO9 SychO9 added this to the 2.0 milestone Sep 15, 2023
@SychO9 SychO9 added type/extensibility breaking-changes javascript Pull requests that update Javascript code labels Sep 15, 2023
@SychO9 SychO9 requested a review from imorland September 15, 2023 10:09
@SychO9 SychO9 marked this pull request as ready for review September 15, 2023 10:09
@SychO9 SychO9 requested a review from a team as a code owner September 15, 2023 10:09
@SychO9
Copy link
Member Author

SychO9 commented Sep 15, 2023

flarum/docs#462

imorland
imorland approved these changes Oct 8, 2023
View reviewed changes
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this very much, this will certainly help with extensibility going forward 👏

@SychO9 SychO9 merged commit 5ab5257 into 2.x Oct 10, 2023
@SychO9 SychO9 deleted the dev-theming-improvements branch October 10, 2023 20:36
@YUCLing
Copy link
Contributor

YUCLing commented Nov 18, 2024

This PR seems to break the affixed sidebar margin to the page top.

framework/framework/core/js/src/forum/components/AffixedSidebar.js

Line 48 in 4feb4a3

top: () => $sidebar.offset().top - $header.outerHeight(true) - parseInt($sidebar.css('margin-top'), 10),

The affix sidebar calculates the offset top from the ul element's margin-top. However, this PR's changes removed it.

@YUCLing YUCLing mentioned this pull request Nov 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imorland imorland imorland approved these changes

Assignees

No one assigned

Labels

breaking-changes javascript Pull requests that update Javascript code needs-documentation prio/high type/extensibility type/theme(ing)

Projects

None yet

Milestone

2.0.0-beta.1

Development

Successfully merging this pull request may close these issues.

3 participants

@SychO9 @YUCLing @imorland