Merged
Conversation
* refactor: move gambits to frontend * Apply fixes from StyleCI * test: GambitManager
SychO9
added
type/feature
breaking-changes
javascript
This was referenced Sep 26, 2023
* chore: drop remaining backend regex gambits * refactor: merge filterer & searcher concept * refactor: adapt extenders * refactor: no longer need to push gambits to `q` * refactor: filters to gambits * refactor: drop shred `Query` namespace * Apply fixes from StyleCI * chore: cleanup * Apply fixes from StyleCI
* chore: leftover gambit references on the backend * chore: namespace
* feat: first iteration of search drivers * feat: indexer API & tweaks * feat: changes after POC driver * fix: properly fire custom observables * chore: remove debugging code * fix: phpstan * fix: custom eloquent events * chore: drop POC usage * test: indexer extender API * fix: extension searcher fails without filters * fix: phpstan * fix: frontend created gambit
# Conflicts: # framework/core/src/Settings/SettingsServiceProvider.php
* feat: allow accessing total search results * feat: allow replacing filters * chore: phpstan
This was referenced Oct 21, 2023
Member
Author
|
Feel free to leave separate reviews in each PR for easier back n fourth if necessary. |
Member
Author
|
Also, proof of concept search driver here: #3902 (comment) |
Member
|
Just need to resolve the conflict, then good to marge. Are you able to tackle that @SychO9 ? |
# Conflicts: # framework/core/src/Search/GambitManager.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3884
Changes proposed in this pull request:
Part of the roadmap, each commit has a separate PR. Changes are made one at a time for easier review/readability.
feel free to review within the related PR even if it's marked as merged.
Necessity
Confirmed
composer test).Required changes: