Skip to content

chore: simplify variable assignment using null coalescing operator#4000

Merged
SychO9 merged 1 commit intoflarum:2.xfrom
datlechin:dat/null-coalescing-operator
Jun 22, 2024
Merged

chore: simplify variable assignment using null coalescing operator#4000
SychO9 merged 1 commit intoflarum:2.xfrom
datlechin:dat/null-coalescing-operator

Conversation

@datlechin
Copy link
Contributor

Simplify variable assignment using null coalescing operator

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@datlechin datlechin requested a review from a team as a code owner June 16, 2024 17:46
@datlechin datlechin changed the title Simplify variable assignment using null coalescing operator chore: Simplify variable assignment using null coalescing operator Jun 16, 2024
@datlechin datlechin changed the title chore: Simplify variable assignment using null coalescing operator chore: simplify variable assignment using null coalescing operator Jun 16, 2024
@SychO9 SychO9 merged commit 19196c2 into flarum:2.x Jun 22, 2024
@datlechin datlechin deleted the dat/null-coalescing-operator branch June 22, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants