[2.x] perf(tags): prevent loading tag state if loaded previously#4009
Merged
SychO9 merged 1 commit intoflarum:2.xfrom Sep 20, 2024
Merged
[2.x] perf(tags): prevent loading tag state if loaded previously#4009SychO9 merged 1 commit intoflarum:2.xfrom
SychO9 merged 1 commit intoflarum:2.xfrom
Conversation
luceos
approved these changes
Aug 3, 2024
Member
luceos
left a comment
There was a problem hiding this comment.
The logic looks sound. I thought the conditional could be simplified, but then we would remove the check for the state actually being null. So 👍 all good.
I would have loved to see the benefit of this on the queries though.
SychO9
approved these changes
Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is similar to #4008, but targets the 2.x branch.
I have not been able to verify if the issue described in #4007 occurs in 2.x, as the Clockwork extension doesn't work with this version, preventing me from observing database queries. Nevertheless, implementing these changes is a precautionary step that can potentially prevent similar issues in the 2.x branch.
Necessity