Skip to content

Search box improvements on tablet devices#4076

Merged
SychO9 merged 1 commit intoflarum:2.xfrom
YUCLing:im/search-box-animating-on-small-screen
Oct 23, 2024
Merged

Search box improvements on tablet devices#4076
SychO9 merged 1 commit intoflarum:2.xfrom
YUCLing:im/search-box-animating-on-small-screen

Conversation

@YUCLing
Copy link
Contributor

@YUCLing YUCLing commented Oct 17, 2024

Fixes #0000

Changes proposed in this pull request:

  • Move onclick event to the whole search area, making the modal open when clicking on the search icon on table devices.
  • Blurs input when onclick, removes the unnecessary animation on tablet devices.

Reviewers should focus on:

Screenshot

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@YUCLing YUCLing requested a review from a team as a code owner October 17, 2024 17:26
@YUCLing YUCLing changed the title Search box improvements on tablet devies Search box improvements on tablet devices Oct 17, 2024
@SychO9 SychO9 merged commit e030c1e into flarum:2.x Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants