fix(webpack): chunk module path checking fails with dotted directories#4179
Merged
SychO9 merged 1 commit intoflarum:2.xfrom Feb 8, 2025
Merged
fix(webpack): chunk module path checking fails with dotted directories#4179SychO9 merged 1 commit intoflarum:2.xfrom
SychO9 merged 1 commit intoflarum:2.xfrom
Conversation
Resolves issues when the path contains unexpected periods
Member
|
what was the result of the logging? we have to know what the issue was first. |
Member
|
nevermind I just saw the discuss comment |
Contributor
Author
|
For completeness sake, here is the logging output (before changing the logic) after adding in the debugging logic you shared: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #0000
Resolves issues when the path contains unexpected dots. Also see https://discuss.flarum.org/d/36971-issues-developing-2x-locally
Changes proposed in this pull request:
Change algorithm for resolving chunks for code splitting in dev mode. GPT'd my way through resolving this issue... No idea if those changes introduced here are actually good or not / also work on other operating systems etc.
Feel free to close this PR and create a new one if this can be done better
Reviewers should focus on:
Leaving this PR as draft because I'm not too confident about this, but in theory, it would be ready for review
Screenshot
Necessity
Confirmed
composer test).Required changes: