[1.x] fix: validate mail settings for whitespace#4245
Merged
Conversation
daeae37 to
38d1dc4
Compare
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
**Fixes #4222 **
Changes proposed in this pull request:
Introduces a reusable trait
ValidatesMailSettingswhich is used by default inSmtpDriverandMailgunDriverto ensure that leading or trailing whitespace throws a validation error, which is displayed in the mail settings UI.I'll also create an accompanying PR to this for
2.xFor
SmtpDriver, we now check for whitespace onmail_hostmail_portmail_username*mail_password** still allows for empty stringFor
MailgunDrivermail_mailgun_secretmail_mailgun_domainis already covered by the regex rule in placeReviewers should focus on:
Screenshot

Necessity
Confirmed
composer test).Required changes: