Skip to content

fix: error when importing from an extension unless enabled#4261

Merged
imorland merged 1 commit into2.xfrom
im/registry
Oct 18, 2025
Merged

fix: error when importing from an extension unless enabled#4261
imorland merged 1 commit into2.xfrom
im/registry

Conversation

@imorland
Copy link
Member

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@imorland imorland marked this pull request as ready for review October 18, 2025 21:06
@imorland imorland requested a review from a team as a code owner October 18, 2025 21:06
@imorland imorland added this to the 2.0.0-beta.4 milestone Oct 18, 2025
@imorland imorland merged commit 005706b into 2.x Oct 18, 2025
28 checks passed
@imorland imorland deleted the im/registry branch October 18, 2025 21:10
@dsevillamartin
Copy link
Member

Would it make sense to warn in debug mode if the extension is NOT enabled? Just instead of failing silently - that way there's a message at all. Ideally just once per calling extension and not per import statement. Just a thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants