Skip to content

[2.x] fix: randomized username fails validation#4283

Merged
imorland merged 3 commits into2.xfrom
im/nicknames
Nov 23, 2025
Merged

[2.x] fix: randomized username fails validation#4283
imorland merged 3 commits into2.xfrom
im/nicknames

Conversation

@imorland
Copy link
Member

@imorland imorland commented Nov 23, 2025

**Fixes #4282 **

Changes proposed in this pull request:
Moves the random username generation to the backend, complies with the username validator

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@imorland imorland added this to the 2.0.0-beta.4 milestone Nov 23, 2025
@imorland imorland changed the title fix: randomized username fails validation [2.x] fix: randomized username fails validation Nov 23, 2025
@imorland imorland marked this pull request as ready for review November 23, 2025 12:10
@imorland imorland requested a review from a team as a code owner November 23, 2025 12:10
@imorland imorland merged commit a37a3b2 into 2.x Nov 23, 2025
28 checks passed
@imorland imorland deleted the im/nicknames branch November 23, 2025 12:54
imorland added a commit that referenced this pull request Jan 13, 2026
* fix: randomized username fails validation

* Apply fixes from StyleCI

* chore: remove debug code

---------

Co-authored-by: StyleCI Bot <bot@styleci.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2.x] Randomly generated nicknames fail validation on registration

2 participants