Skip to content

[2.x] fix: mentions not always eager loaded in the notification email context#4308

Merged
imorland merged 1 commit into2.xfrom
im/fix-email-mentions
Dec 19, 2025
Merged

[2.x] fix: mentions not always eager loaded in the notification email context#4308
imorland merged 1 commit into2.xfrom
im/fix-email-mentions

Conversation

@imorland
Copy link
Member

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@imorland imorland requested a review from a team as a code owner December 19, 2025 22:35
@imorland imorland added this to the 2.0.0-beta.5 milestone Dec 19, 2025
@imorland imorland merged commit f367a57 into 2.x Dec 19, 2025
35 checks passed
@imorland imorland deleted the im/fix-email-mentions branch December 19, 2025 22:47
imorland added a commit that referenced this pull request Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant