Skip to content

[2.x] fix: missing translation for legacy search component#4314

Merged
imorland merged 1 commit into2.xfrom
im/legacy-search
Dec 20, 2025
Merged

[2.x] fix: missing translation for legacy search component#4314
imorland merged 1 commit into2.xfrom
im/legacy-search

Conversation

@imorland
Copy link
Member

Fixes #4297

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@imorland imorland added this to the 2.0.0-beta.5 milestone Dec 20, 2025
@imorland imorland requested a review from a team as a code owner December 20, 2025 10:46
@imorland imorland merged commit 3040cb3 into 2.x Dec 20, 2025
35 checks passed
@imorland imorland deleted the im/legacy-search branch December 20, 2025 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[2.x] Legacy Search component uses incorrect translation key for clear button

1 participant