[2.x] [realtime] Fixed an issue where tag-specified discussion pushing could not work#4320
Merged
imorland merged 2 commits intoflarum:2.xfrom Dec 29, 2025
Merged
Conversation
imorland
approved these changes
Dec 29, 2025
Member
imorland
left a comment
There was a problem hiding this comment.
Thank you for this, we really appreciate your contribution!
imorland
pushed a commit
that referenced
this pull request
Jan 13, 2026
…g could not work (#4320) * Update NewActivity.js * format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #0000
I have located this issue long ago, just publishing now because former
blomstra/realtimeis not open for PRs.Fixed an issue where tag-specified discussion pushing could not work. The original code tried to index an
idfrom an array oftagswhich is obviously wrong.My fix has only been tested and proven work on my own
1.xdeployment, please tell me if anything has changed.There could be something slug-related to reproduce the issue.
Changes proposed in this pull request:
Reviewers should focus on:
See above.
Screenshot
Necessity
Confirmed
composer test).Required changes: