Skip to content

[2.x] [realtime] Fixed an issue where tag-specified discussion pushing could not work#4320

Merged
imorland merged 2 commits intoflarum:2.xfrom
edgeinfinity1:realtime_fix_2
Dec 29, 2025
Merged

[2.x] [realtime] Fixed an issue where tag-specified discussion pushing could not work#4320
imorland merged 2 commits intoflarum:2.xfrom
edgeinfinity1:realtime_fix_2

Conversation

@edgeinfinity1
Copy link
Contributor

Fixes #0000
I have located this issue long ago, just publishing now because former blomstra/realtime is not open for PRs.

Fixed an issue where tag-specified discussion pushing could not work. The original code tried to index an id from an array of tags which is obviously wrong.

My fix has only been tested and proven work on my own 1.x deployment, please tell me if anything has changed.
There could be something slug-related to reproduce the issue.

Changes proposed in this pull request:

Reviewers should focus on:

See above.

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@edgeinfinity1 edgeinfinity1 requested a review from a team as a code owner December 25, 2025 04:58
@imorland imorland added this to the 2.0.0-beta.6 milestone Dec 29, 2025
@imorland imorland changed the title Fixed an issue where tag-specified discussion pushing could not work [2.x] [realtime] Fixed an issue where tag-specified discussion pushing could not work Dec 29, 2025
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this, we really appreciate your contribution!

@imorland imorland merged commit 9c1f2ff into flarum:2.x Dec 29, 2025
28 checks passed
imorland pushed a commit that referenced this pull request Jan 13, 2026
…g could not work (#4320)

* Update NewActivity.js

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants