server: track bids received to clarify empty response logs#892
Open
mark-liu wants to merge 1 commit intoflashbots:developfrom
Open
server: track bids received to clarify empty response logs#892mark-liu wants to merge 1 commit intoflashbots:developfrom
mark-liu wants to merge 1 commit intoflashbots:developfrom
Conversation
When all relay bids are filtered (e.g. below min-bid), the info log says "no bid received" which is misleading. Track the number of bids returned by relays in bidResp and distinguish between genuinely receiving nothing vs filtering everything out. Fixes flashbots#869. Also addresses flashbots#489.
Author
|
Gentle ping — this is a small observability improvement. Happy to adjust if needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
When all relay bids are filtered (e.g. below min-bid), the info log says
"no bid received" — but bids were received, they just weren't acceptable.
This tracks the count of bids returned by relays in
bidRespand uses itto distinguish between genuinely receiving nothing vs filtering everything out.
bidsReceivedset fromlen(relayBids)after relay goroutines complete"no acceptable bid received" bidsReceived=Nwhen bids were filtered"no bid received"when relays truly returned nothingTestGetHeaderBidscovering both cases⛱ Motivation and Context
Fixes #869. Also addresses #489.
Running at default (info) log level, the only signal a validator gets when
bids exist but fall below min-bid is "no bid received". The debug-level
"bid received" and "ignoring bid below min-bid value" logs don't show up
unless you explicitly lower the level. This has confused operators debugging
why blocks were built locally.
📚 References
✅ I have run these commands
make lintmake test-racego mod tidyNote:
make test-racetimes out ondevelop(without this PR's changes)due to
TestGetPayload/"A relay which does not provide the bid gets a JSON request"hanging under the race detector. All tests prior to that pass,including the new tests added here.