fix: use batch_sampler for HybridEnvSampler in DataLoader#126
Merged
Conversation
The HybridEnvSampler yields batches of indices (lists), not individual indices. DataLoader's `sampler` parameter expects individual indices, while `batch_sampler` expects batches. Using `sampler=` caused: ValueError: not enough values to unpack (expected 4, got 1) because collate_fn received raw indices instead of dataset items. Also adds integration tests to catch this regression: - test_hybrid_env_sampler_dataloader_integration: verifies correct usage - test_hybrid_env_sampler_wrong_usage_fails: documents the bug 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
build_dataloaderto usebatch_sampler=instead ofsampler=for HybridEnvSamplersampler=caused collate_fn to receive raw indices instead of dataset itemsError Fixed
Test plan
test_hybrid_env_sampler_dataloader_integration- verifies correct batch structuretest_hybrid_env_sampler_wrong_usage_fails- documents the bug🤖 Generated with Claude Code