Conversation
gornekich
requested review from
Astrrra,
DrZlo13,
hedger,
nminaylov and
skotopes
as code owners
|
Compiled f7 firmware for commit |
|
PVS-Studio report for commit |
Member
Author
|
@nvx @pcunning Also flipperdevices/flipperzero-good-faps#62 PR is temporary. I will split it to make code review easier soon. Now I just want to be sure that nfc library works correctly. |
nvx
reviewed
Oct 24, 2023
skotopes
previously approved these changes
Oct 28, 2023
skotopes
approved these changes
Oct 28, 2023
EarthC123
pushed a commit
to EarthC123/flipperzero-firmware
that referenced
this pull request
Dec 8, 2023
* firmware: remove nfc lib build settings section * furi hal nfc: fix nfc irq gpio deinit * lib nfc: remove deprecated exception from sources * nfc: use ASK demodulator in transparent mode * mf ultralight: add upper page bound for NTAGI2C1K * furi hal nfc: set event if nfc event was started * nfc: fix PVS warnings * lib signal reader: remove gpio pull setting in alloc * furi: added math.h include for compatibility with existing apps * nfc: remove resolved TODO in mf desfire poller * bump api symbol version Co-authored-by: hedger <hedger@nanode.su> Co-authored-by: あく <alleteam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Verification
Checklist (For Reviewer)