Skip to content

Comments

fbt: improvements#3217

Merged
skotopes merged 7 commits intodevfrom
hedger/fbt_improvements_pt5
Nov 15, 2023
Merged

fbt: improvements#3217
skotopes merged 7 commits intodevfrom
hedger/fbt_improvements_pt5

Conversation

@hedger
Copy link
Member

@hedger hedger commented Nov 15, 2023 •
edited by skotopes
Loading

What's new

  • fbt, ufbt: fixed path handling for paths with spaces
  • fbt: added CDEFINES support for external apps - now it sets given defines in apps' private environment
  • fbt, ufbt: fixed FAP_VERSION define - now it's a string
  • fbt: fap_private_libs: path & library linkage handling improvements

Verification

  • try debug, flash_usb_full targets with fbt && ufbt

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@github-actions
Copy link

github-actions bot commented Nov 15, 2023 •
edited
Loading

Compiled f7 firmware for commit d1de1e6e:

@hedger hedger marked this pull request as ready for review November 15, 2023 15:13
@hedger hedger added Bug Build System & Scripts fbt, scripts and toolchain-related labels Nov 15, 2023
@hedger hedger changed the title Hedger/fbt improvements pt5 fbt: improvements Nov 15, 2023
@skotopes skotopes merged commit 98d5718 into dev Nov 15, 2023
@skotopes skotopes deleted the hedger/fbt_improvements_pt5 branch November 15, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DrZlo13 DrZlo13 Awaiting requested review from DrZlo13 DrZlo13 is a code owner

@drunkbatya drunkbatya Awaiting requested review from drunkbatya

@nminaylov nminaylov Awaiting requested review from nminaylov nminaylov is a code owner

@gornekich gornekich Awaiting requested review from gornekich gornekich is a code owner

1 more reviewer

@skotopes skotopes skotopes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug Build System & Scripts fbt, scripts and toolchain-related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hedger @skotopes