Mifare Classic nested auth support#3238
Merged
skotopes merged 2 commits intoflipperdevices:devfrom Dec 1, 2023
Merged
Conversation
augustozanellato
requested review from
Astrrra,
DrZlo13,
gornekich,
hedger,
nminaylov and
skotopes
as code owners
hedger
added
NFC
gornekich
previously approved these changes
Nov 22, 2023
Member
gornekich
left a comment
gornekich
left a comment
There was a problem hiding this comment.
Hello @augustozanellato
Perfect work! Tested your application, everything is great.
Thank you!
skotopes
previously approved these changes
Dec 1, 2023
skotopes
approved these changes
Dec 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Added support for mifare classic nested auth.
This PR is a follow-up from #3176 and applies the suggestions received, mainly having two different functions for nested and plain auth instead of adding a nested flag.
Verification
Checklist (For Reviewer)