Conversation
|
Compiled f7 firmware for commit |
|
PVS-Studio report for commit |
gornekich
previously approved these changes
Jan 24, 2024
gornekich
previously approved these changes
Feb 6, 2024
hedger
approved these changes
Feb 6, 2024
| // In layout 0x5 balance in bits 165:185 ( from sector start, length 20). | ||
|
|
||
| if(layout == TroikaLayoutE && sub_layout == TroikaSublayout3) { | ||
| const uint8_t* temp_ptr = &data->block[start_block_num + 1].data[7]; |
Member
There was a problem hiding this comment.
use a common function in both branches?
|
|
||
| TroikaLayout result = TroikaLayoutUnknown; | ||
| switch(layout) { | ||
| case 0x2: |
Member
There was a problem hiding this comment.
pointless - enum values are equal to switch cases, we can use them as-is.
So, just check for known values and cast to enum, return Unknown otherwise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Verification
Checklist (For Reviewer)