add additional keys to elite dict#89
Merged
skotopes merged 3 commits intoflipperdevices:devfrom Dec 20, 2023
Merged
Conversation
Contributor
Author
|
Elite.picopass.json remove the .json to use the picopass elite keyed test file |
bettse
previously approved these changes
Dec 19, 2023
Collaborator
bettse
left a comment
There was a problem hiding this comment.
I don't love that the regular read will also check all of these and doesn't have the progress bar, but that can be a future improvement
skotopes
approved these changes
Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new
Verification
#define PICOPASS_DEBUG_IGNORE_BAD_RMACdisabled (function undefined) should emulate elite correctly for testing purposes.Checklist (For Reviewer)