This repository was archived by the owner on Dec 5, 2024. It is now read-only.
fix: change initial position style based on positionFixed prop#336
Merged
FezVrasta merged 2 commits intofloating-ui:masterfrom Feb 25, 2020
Merged
fix: change initial position style based on positionFixed prop#336FezVrasta merged 2 commits intofloating-ui:masterfrom
FezVrasta merged 2 commits intofloating-ui:masterfrom
Conversation
Contributor
Author
|
Quoting a comment from @atomiks on floating-ui/floating-ui#1009
That makes total sense to me, although there doesn't appear to be a way to do that with the current |
Contributor
Author
|
@FezVrasta any suggestions for this PR or anything I can do to help get this merged? |
FezVrasta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a scenario where I am autofocusing an element appearing inside of a popper, and that is causing the page to scroll to the top when initially opened. A similar issue can be found here:
mui/material-ui#16740
Their solution was to add
position: fixedto the initial styles on the popper, but this library doesn't offer a way to do that. This PR makes it so that initial position style will either beabsoluteorfixedbased on thepositionFixedprop provided to the Popper component.