Open
Conversation
214fb3e to
a1d67b6
Compare
zmitchell
approved these changes
May 29, 2025
rossturk
suggested changes
May 29, 2025
There was a problem hiding this comment.
Please make sure this works across all of our footprints (including wsl and flox containerize) - I have tried this before and reverted after encountering issues.
Also, be good to check that this can still support multiple instances on the same host (configured with alternate ports).
Previously, the default configuration for flox/postgres uses both a socket and a TCP connection. This was both redundant and caused Postgres not to start in several scenarios -- primarily because the postgres socket file path was deep in the .flox structure, which already might be deep in the filesystem. The maximum lenght for a file socket path on MacOS is 103 characters. If it's longer than that, PG will not start. This change simply removes the call to `-c socket` because it's redundant with the way Postgres is already configured via this env. Additionally, the presence of PGHOST cause the primary go Postgres library to panic as it tries to parse that even when the presence of TCP connection information is available. I actually wonder if PGHOST should be renamed to PGRUN or something else, as it's only used to locate the `/run` directory.
a1d67b6 to
365c4c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Previously, the default configuration for flox/postgres uses both a socket and
a TCP connection. This was both redundant and caused Postgres not to start in
several scenarios -- primarily because the postgres socket file path was deep
in the .flox structure, which already might be deep in the filesystem. The
maximum lenght for a file socket path on MacOS is 103 characters. If it's
longer than that, PG will not start. This change simply removes the call to
-c socketbecause it's redundant with the way Postgres is already configured viathis env.
Additionally, the presence of PGHOST cause the primary go Postgres library to
panic as it tries to parse that even when the presence of TCP connection
information is available.