Skip to content

Remove unnecessary bundler installation#1591

Merged
kenhys merged 1 commit intofluent:masterfrom
Watson1978:remove-bundler-installation
Dec 18, 2025
Merged

Remove unnecessary bundler installation#1591
kenhys merged 1 commit intofluent:masterfrom
Watson1978:remove-bundler-installation

Conversation

@Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Dec 18, 2025

Ruby 3.4 has bundled bundler.

$ docker run -it --rm fluent/fluentd:v1.19.1-debian-amd64 bundle --version
Bundler version 2.6.9

We have installed a version older than that, but older versions won't be used unless we explicitly specify a version with bundle _2.4.17_.

And it is unused.

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
@Watson1978 Watson1978 requested a review from kenhys December 18, 2025 08:08
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Good catch!

@kenhys kenhys merged commit 88427e9 into fluent:master Dec 18, 2025
38 checks passed
@Watson1978 Watson1978 deleted the remove-bundler-installation branch December 18, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants