Support fmt::runtime with wchar_t in fmt::format_to_n#4715
Open
sunmy2019 wants to merge 4 commits intofmtlib:masterfrom
Open
Support fmt::runtime with wchar_t in fmt::format_to_n#4715sunmy2019 wants to merge 4 commits intofmtlib:masterfrom
sunmy2019 wants to merge 4 commits intofmtlib:masterfrom
Conversation
vitaut
requested changes
Mar 14, 2026
Contributor
vitaut
left a comment
There was a problem hiding this comment.
Thanks for the PR. We shouldn't modify base.h for this.
Contributor
Author
How about reimplementing similar functions in |
Contributor
|
I think what we need here as an overload of |
|
what about char16_t? |
Contributor
|
Let's focus on |
Contributor
Author
I use wformat_string in the new implementation. This may remove previous support of char type not in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #4714