chore(IWYU): Remove some redundant includes#4758
Merged
Merged
Conversation
28f4348 to
f0f9900
Compare
f0f9900 to
33b3a45
Compare
Contributor
Author
#include "fmt/os.h" // fmt::system_category
#include "fmt/ranges.h"
#include "gtest-extra.h" // StartsWith
#ifdef __cpp_lib_filesystem
TEST(std_test, path) {
using std::filesystem::path;
// ...
// ...
// ...
// ...
EXPECT_EQ(fmt::format("{:?}", path(L"\xD800")), "\"\\ud800\"");
# endif
}
// Intentionally delayed include to test #4303
# include "fmt/ranges.h"
|
Contributor
|
LGTM. Do you still plan to make changes to this PR or shall we merge? |
Contributor
Author
Thank you for your review. We can mergw. At the moment, I haven’t been able to find the time to look into the situation I mentioned in the comment above. |
Contributor
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked header dependencies using
IWYUand removed includes identified as redundant. I check potential false positives and some warnings were addressed here — not all.fmtproject has platform-specific guards and backward-compatibility build paths that's why I tried to approach it as minimally as possible.I am marking this PR draft. I want analyze CI results and check again this changes.