Validate the written chunks when using a seed#214
Merged
folbricht merged 1 commit intofolbricht:masterfrom Feb 25, 2022
Merged
Conversation
Contributor
Author
|
This should have a negligible impact on performance. However if you prefer I can move this additional check under a launch option. |
folbricht
reviewed
Feb 25, 2022
Owner
|
I agree that it shouldn't add to much overhead since the data was just written and it should be read back from buffered memory. |
The seed values are validated at the beginning when we create the extraction "plan". However a seed might point to a location where is possible to read and write data. In that case, even if at the beginning we validated the seed data, the assumption that when we use `WriteInto()` the seed data is still valid might not be true anymore. For this reason we should also re-validate the written data to ensure that what ended up in the destination is exactly what we were expecting. Signed-off-by: Ludovico de Nittis <ludovico.denittis@collabora.com>
RyuzakiKK
force-pushed
the
validate_written_data
branch
from
0f2c999 to
80b0f9c
Compare
folbricht
approved these changes
Feb 25, 2022
JeremieA
pushed a commit
to InSimo/desync
that referenced
this pull request
Apr 10, 2026
The seed values are validated at the beginning when we create the extraction "plan". However a seed might point to a location where is possible to read and write data. In that case, even if at the beginning we validated the seed data, the assumption that when we use `WriteInto()` the seed data is still valid might not be true anymore. For this reason we should also re-validate the written data to ensure that what ended up in the destination is exactly what we were expecting. Signed-off-by: Ludovico de Nittis <ludovico.denittis@collabora.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The seed values are validated at the beginning when we create the
extraction "plan".
However a seed might point to a location where is possible to read and
write data. In that case, even if at the beginning we validated the seed
data, the assumption that when we use
WriteInto()the seed data isstill valid might not be true anymore.
For this reason we should also re-validate the written data to ensure
that what ended up in the destination is exactly what we were expecting.