Skip to content

Support passing AWS session token via environment variable#226

Merged
folbricht merged 2 commits intofolbricht:masterfrom
matshch:aws-session-token
Oct 26, 2022
Merged

Support passing AWS session token via environment variable#226
folbricht merged 2 commits intofolbricht:masterfrom
matshch:aws-session-token

Conversation

@matshch
Copy link
Copy Markdown
Contributor

@matshch matshch commented Oct 24, 2022

desync already supports taking aws_session_token from shared credentials file, but it is not convenient to store token there if it is received by another application that will call desync. This commit allows to pass session token via environment variable like other credentials.

Also while we there, lets add support for the same environment variables as AWS CLI and AWS SDKs accept.

Co-authored-by: Aleksejs Lucko lu4ik@yandex-team.ru

desync already supports taking aws_session_token from shared credentials
file, but it is not convenient to store token there if it is received by
another application that will call desync. This commit allows to pass
session token via environment variable like other credentials.

Co-authored-by: Aleksejs Lucko <lu4ik@yandex-team.ru>
@shcheglovnd
Copy link
Copy Markdown

Good job!

Comment thread README.md Outdated
Most applications and libraries support same environment variables as
AWS CLI and AWS SDKs. It will be more convenient if desync will also
support them.

Co-authored-by: Aleksejs Lucko <lu4ik@yandex-team.ru>
Copy link
Copy Markdown
Owner

@folbricht folbricht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you

@folbricht folbricht merged commit a883b9b into folbricht:master Oct 26, 2022
JeremieA pushed a commit to InSimo/desync that referenced this pull request Apr 10, 2026
…#226)

* Support passing AWS session token via environment variable

desync already supports taking aws_session_token from shared credentials
file, but it is not convenient to store token there if it is received by
another application that will call desync. This commit allows to pass
session token via environment variable like other credentials.

Co-authored-by: Aleksejs Lucko <lu4ik@yandex-team.ru>

* Support same environment variables as AWS SDKs

Most applications and libraries support same environment variables as
AWS CLI and AWS SDKs. It will be more convenient if desync will also
support them.

Co-authored-by: Aleksejs Lucko <lu4ik@yandex-team.ru>

Co-authored-by: Aleksejs Lucko <lu4ik@yandex-team.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants