Adds basic pre-commit#260
Merged
folbricht merged 1 commit intofolbricht:masterfrom Mar 10, 2024
Merged
Conversation
Contributor
Author
|
I don't believe anything in this commit should be making the build fail, nor the windows build specifically. |
folbricht
approved these changes
Mar 10, 2024
JeremieA
pushed a commit
to InSimo/desync
that referenced
this pull request
Apr 10, 2026
Co-authored-by: bstrausser <bstrausser@locusrobotics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I continually forget to do things before commit, in most projects I rely on pre-commit (maybe to my detriment).
This adds a basic pre-commit script. https://pre-commit.com/
This is completely opt in. If a user doesn't use pre-commit. Then nothing happens locally or in ci.
I only selected the least opinionated of all available hooks. I left the opinionated hooks in, if those are something you'd want for the project.
The unit test hook is currently commented out because of a failing cmd unit-test. It should be re-enabled.