Fix sparse file test offset/length#263
Merged
folbricht merged 2 commits intofolbricht:masterfrom Mar 10, 2024
Merged
Conversation
folbricht
reviewed
Mar 10, 2024
| // Read a few random ranges and compare to the expected blob content | ||
| for i := 0; i < 1000; i++ { | ||
| length := rand.Intn(int(index.Index.ChunkSizeMax)) | ||
| offset := rand.Intn(int(index.Length()) - length) |
Owner
There was a problem hiding this comment.
Shouldn't this be?
offset := rand.Intn(int(index.Length()) - length - 1)
Contributor
Author
There was a problem hiding this comment.
Three hard things in computer science: off-by-one errors and naming things.
I'll fix it up.
folbricht
approved these changes
Mar 10, 2024
JeremieA
pushed a commit
to InSimo/desync
that referenced
this pull request
Apr 10, 2026
* Fix sparse file test offset/length * Fix off-by-one error --------- Co-authored-by: bstrausser <bstrausser@locusrobotics.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #262