feat: add replica identity on tables without primary key

[gfyrag]

No description provided.

[coderabbitai]

Walkthrough

The pull request bumps the minimal schema version from 48 to 49 and adds a new SQL migration script that adds missing primary keys to three tables (transactions, accounts, logs) using their existing indexes.

Changes

Cohort / File(s)	Summary
Schema Version Update internal/storage/bucket/default_bucket.go	Incremented MinimalSchemaVersion constant from 48 to 49 to reflect the new baseline schema requirement.
Primary Key Migration internal/storage/bucket/migrations/45-fix-missing-primary-keys/up.sql	New migration script that adds primary keys to transactions, accounts, and logs tables by promoting existing indexes as the respective primary keys.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Hops and wiggles with glee,
Primary keys found—one, two, three!
From forty-eight to forty-nine we leap,
Database integrity, databases keep. 🔐

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title mentions 'replica identity' but the actual changes involve adding primary keys via migrations and updating the schema version constant, not replica identity configuration.	Update the title to reflect the actual changes, such as 'feat: add primary keys to tables using existing indexes' or 'chore: update minimal schema version to 49'.
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess relevance to the changeset.	Add a description explaining the purpose of the schema migration, why primary keys are being added, and how it relates to the minimal schema version bump.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/replica-identity

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@internal/storage/bucket/migrations/45-add-replica-identity/up.sql`:
- Around line 6-17: The loop over _system.ledgers is unnecessary; remove the FOR
loop and its body and instead set the search_path once and execute the three
ALTER TABLE statements exactly once: ALTER TABLE transactions REPLICA IDENTITY
USING INDEX transactions_ledger, ALTER TABLE accounts REPLICA IDENTITY USING
INDEX accounts_ledger, and ALTER TABLE logs REPLICA IDENTITY USING INDEX
logs_ledger; remove references to vsql and the loop (FOR ledger ... END LOOP) so
the statements run only a single time in this migration.

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@internal/storage/bucket/migrations/45-add-replica-identity/up.sql`:
- Line 3: The migration uses a session-level "set search_path = '{{ .Schema
}}';" which can leak into subsequent migrations; change it to use "SET LOCAL
search_path = '{{ .Schema }}';" so the search_path change is scoped to the
current DO block/transaction. Locate the "set search_path" statement in the
migration (up.sql) and replace it with the local-scoped variant to prevent
session leakage when the connection is reused.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.22%. Comparing base (1cfd498) to head (2f91490).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1237      +/-   ##
==========================================
+ Coverage   74.63%   82.22%   +7.59%     
==========================================
  Files         198      198              
  Lines       10410    10224     -186     
==========================================
+ Hits         7769     8407     +638     
+ Misses       1512     1325     -187     
+ Partials     1129      492     -637     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.