chore: backport CI improvements to v2.3#1278
Conversation
- default action: disable nix cache (downloading from cache.nixos.org is faster), use go env for proper GOCACHE/GOMODCACHE paths, add golangci-lint cache - all workflows: use treeless clones (filter: tree:0) for faster checkout - main.yml: add build provenance attestations, upload goreleaser metadata, update Deploy job to tailscale v4 with OIDC auth - benchmark workflows: fix report path, allow workflow_dispatch trigger for comparison, fix trailing whitespace Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughReordered Justfile pre-commit targets, added a fmt target, conditioned speakeasy invocation on SPEAKEASY_API_KEY, and adjusted lint navigation and flags. Refactored flake.nix: fixed nixpkgs URL, removed go overlay mapping, changed unfree handling to a predicate, corrected speakeasy hash, and split devShells packages into stable and other lists. Updated a test to use deferred.FromValue. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- flake.nix: use allowUnfreePredicate instead of allowUnfree, remove goVersion overlay in favor of explicit go_1_24, organize packages into named lists, fix aarch64-linux hash typo - Justfile: reorder pre-commit deps, add golangci-lint version print, add local build tag, add fmt recipe, guard generate-client with SPEAKEASY_API_KEY, fix missing newline at EOF Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The local_env_test.go was using NewValuedDeferred from a dot-import of go-libs/v3/testing/utils which doesn't export that symbol. Replace with deferred.FromValue from go-libs/v3/testing/deferred. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v2.3 #1278 +/- ##
================================================
+ Coverage 81.71% 81.73% +0.02%
================================================
Files 187 187
Lines 9078 9078
================================================
+ Hits 7418 7420 +2
+ Misses 1220 1219 -1
+ Partials 440 439 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Sylvain Rabot <sylvain@formance.com>
Signed-off-by: Sylvain Rabot <sylvain@formance.com>
Summary
go envfor proper GOCACHE/GOMODCACHE paths, add golangci-lint cachefilter: tree:0) for faster checkoutTest plan
🤖 Generated with Claude Code