PropertyList component to match design system requirements#597
Open
Mahek-Vasoya wants to merge 8 commits intomasterfrom
Open
PropertyList component to match design system requirements#597Mahek-Vasoya wants to merge 8 commits intomasterfrom
Mahek-Vasoya wants to merge 8 commits intomasterfrom
Conversation
mkrause
requested changes
Mar 3, 2026
| </div> | ||
|
|
||
| {/* Toggle */} | ||
| {enableClamping && isStringValue && ( |
Collaborator
There was a problem hiding this comment.
I wonder if we also should have a way that we do not show the "View more" button if the text is not actually clamped. This would be hard to do however because we cannot reliably detect if the browser has cut off the text (just counting characters is not sufficient). So currently we leave it up to the consumer to not enable clamping if the text is short?
Collaborator
Author
There was a problem hiding this comment.
I will try to check a few things on this. I guess we can achieve this, but that can be a follow-up issue.
mkrause
requested changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new implementation of
PropertyListandPropertywith built-in support for multi-line clamping and expandable values.Key Features
Layout compatibility
horizontalandverticalorientations.sizeprop (small,medium,large,full-width).Multi-line clamping (
expandable)clampLines(default:4)....) when content overflows.Expand / Collapse behavior
Propertycomponent.Notes
valueis a string.Example