changed to_title to to_sentence and implemented correct to_title #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aman-godara
changed the title
awvwgk
requested changes
May 15, 2021
Co-authored-by: Sebastian Ehlert <[email protected]>
Member
Author
|
Please rerun the workflow once. I don't think there is any error in the code. |
Member
Yes, this is unrelated to your changes in this PR. It looks like the Makefile is missing a dependency for stdlib_math.o: stdlib_kinds.o |
Member
Author
Ok!, I will make the necessary changes. |
jvdp1
reviewed
May 16, 2021
Member
jvdp1
left a comment
jvdp1
left a comment
There was a problem hiding this comment.
It sounds good to me.
The specs for to_title must be adapted.
The specs for to_sentece must be added.
Co-authored-by: Jeremie Vandenplas <[email protected]>
awvwgk
approved these changes
May 21, 2021
jvdp1
approved these changes
May 21, 2021
Member
jvdp1
left a comment
jvdp1
left a comment
There was a problem hiding this comment.
Thanks! Approved pending small suggestions
Co-authored-by: Jeremie Vandenplas <[email protected]>
Member
|
Thanks for this patch. I'll go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status: Code is open for review
Concerning PR: #372
Tasks:
Closes #372