Fix iomsg allocation in save_npy #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awvwgk
approved these changes
Dec 15, 2021
Member
awvwgk
left a comment
awvwgk
left a comment
There was a problem hiding this comment.
Good catch, thanks for fixing it
|
|
||
| if (present(iomsg)) then | ||
| iomsg = "Failed to write array to file '"//filename//"'" | ||
| if (stat /= 0) then |
Member
There was a problem hiding this comment.
Why not check for present(iomsg) .and. stat /= 0?
Member
Author
There was a problem hiding this comment.
I did that initially, but then decided to go with nested if's to avoid the .and..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently just a draft for a minor issue remaining in #581.
I've added a test to check that iomsg is deallocated if present, although this should technically be guaranteed by a standard-conforming compiler when the
intent(out)attribute is present.To make sure the message gets allocated I need a way to trigger
stat /= 0. Is their any known way of doing this for a new file?On more thought, I'm afraid that both
statandiomsgonly communicate the result of the commandclose(), and not if opening or writing were unsuccessful. I'm not sure whether the standard stipulates these commands be connected (in other words whether the same I/O error will trigger the same iostat flag in any of the three commands).