fix(primitives): FoundryTransactionRequest based on WithOtherFields<TransactionRequest>
#12786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s<TransactionRequest>` - Fixed `FoundryTransactionRequest::build_typed_tx` to use `WithOtherFields` to handle all eth tx types and deposit - Use `derive_more`, for simple conversions
mablr
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
onbjerg
approved these changes
Dec 10, 2025
mattsse
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Towards #12784
FoundryTransactionRequestprimitive impl was flawed as it can't handle eip4844 txs.Solution
FoundryTransactionRequest::build_typed_txto useWithOtherFieldsto handle all eth tx types and depositderive_more, for simple conversionsPR Checklist