feat: add ignored_error_codes_from config option#13841
feat: add ignored_error_codes_from config option#13841mattsse merged 5 commits intofoundry-rs:masterfrom
Conversation
ndavd
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
I think this makes a lot of sense and would be a nice addition
| "transfer-deprecated", | ||
| "natspec-memory-safe-assembly-deprecated", | ||
| ] | ||
| ignored_error_codes_from = [] |
There was a problem hiding this comment.
could you please give an example how this would look like in the toml, I assume like [[..],[...]]
There was a problem hiding this comment.
Exactly, it would look like this:
ignored_error_codes_from = [
["test", ["code-size"]], # ignore contract size only in test
["lib", ["code-size", "license"]], # ignore size and license in lib
]Should I add that example somewhere?
…er (#361) - Related to foundry-rs/foundry#9516 - Blocking foundry-rs/foundry#13841
mablr
left a comment
mablr
left a comment
There was a problem hiding this comment.
@ndavd fyi we moved foundry-compilers crate to https://github.com/foundry-rs/foundry-core/tree/main/crates/compilers
| idna_adapter = "=1.1.0" | ||
|
|
||
| [patch.crates-io] | ||
| foundry-compilers = { git = "https://github.com/ndavd/foundry-compilers", branch = "feat/ignored_error_codes_from" } |
There was a problem hiding this comment.
This needs to be removed before merge
There was a problem hiding this comment.
Was just checking this. I noticed foundry-compilers is still imported from the old repository. Should I change it?
There was a problem hiding this comment.
They will be released soon on crates.io
There was a problem hiding this comment.
@ndavd fyi foundry-compilers/0.20.0 was released
There was a problem hiding this comment.
Thanks. It's now up-to-date with master and I've removed the patch which is no longer needed. Should be good now.
4 participants
Adds
ignored_error_codes_fromconfig option that allows ignoring error codes from files matching specific path prefixes.Solves #9516
Example usage
Add to
foundry.toml:foundry-compilersdep (34ebdc5) until the PR is mergedPR Checklist