fix(lint): catch divide-before-multiply on rhs of multiplication#14257
Open
cuiweixie wants to merge 1 commit intofoundry-rs:masterfrom
Open
fix(lint): catch divide-before-multiply on rhs of multiplication#14257cuiweixie wants to merge 1 commit intofoundry-rs:masterfrom
cuiweixie wants to merge 1 commit intofoundry-rs:masterfrom
Conversation
DivideBeforeMultiply only inspected the left operand of *. Also scan\nthe right operand so patterns like x * (y / z) are reported, matching\nthe lint's precision guidance.
cuiweixie
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mattsse,
onbjerg and
zerosnacks
as code owners
cuiweixie
requested review from
figtracer,
mablr and
stevencartavia
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
divide-before-multiplylint only walked the left operand of a multiplication, sox * (y / z)was missed. Bind the right-handBinaryoperand and emit when either side contains a division.Test plan
cargo check -p forge-lint