fix(anvil): sync state snapshots with reset and revert#14317
Open
solanaXpeter wants to merge 2 commits intofoundry-rs:masterfrom
Open
fix(anvil): sync state snapshots with reset and revert#14317solanaXpeter wants to merge 2 commits intofoundry-rs:masterfrom
solanaXpeter wants to merge 2 commits intofoundry-rs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
State snapshot metadata can diverge from backend state.
anvil_resetclears chain and DB state without clearingactive_state_snapshots, andrevert_state_snapshotremoved metadata before the DB revert succeeded. That can leaveanvil_metadatareporting stale snapshots and makeevm_revertdepend on a partially applied rollback path.Solution
Clear
active_state_snapshotsin both reset paths, and only remove a snapshot entry after the DB revert succeeds. When the backing snapshot block or DB snapshot is already gone, drop the stale metadata entry and returnfalsewithout mutating chain state. Added regression tests for failed revert, in-memory reset, and fork reset paths.PR Checklist