fix(config): respect custom Etherscan URL in cast/forge commands#14319
Open
FredPhilipy wants to merge 3 commits intofoundry-rs:masterfrom
Open
fix(config): respect custom Etherscan URL in cast/forge commands#14319FredPhilipy wants to merge 3 commits intofoundry-rs:masterfrom
FredPhilipy wants to merge 3 commits intofoundry-rs:masterfrom
Conversation
FredPhilipy
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse,
onbjerg and
zerosnacks
as code owners
mablr
requested changes
Apr 15, 2026
Contributor
Author
Thanks! fixed. |
mablr
previously approved these changes
Apr 15, 2026
Contributor
Author
Yeah just realized it, fixed already. |
mablr
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several commands (
cast storage,cast creation-code,cast interface,forge clone) were bypassing the user's custom Etherscan URL configuration infoundry.tomlby usingClient::new(chain, api_key)directly. Changed these to useget_etherscan_config_with_chain()+into_client()pattern, consistent with the fix in verify module. This enables these commands to work with private chains and custom block explorers.