fix(config): validate optimizer_runs does not exceed u32::MAX#14354
Merged
zerosnacks merged 2 commits intofoundry-rs:masterfrom Apr 17, 2026
Merged
fix(config): validate optimizer_runs does not exceed u32::MAX#14354zerosnacks merged 2 commits intofoundry-rs:masterfrom
optimizer_runs does not exceed u32::MAX#14354zerosnacks merged 2 commits intofoundry-rs:masterfrom
Conversation
FredPhilipy
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse,
onbjerg,
stevencartavia and
zerosnacks
as code owners
figtracer
approved these changes
Apr 16, 2026
Collaborator
figtracer
left a comment
figtracer
left a comment
There was a problem hiding this comment.
doesn't hurt to have this check i think
mablr
approved these changes
Apr 17, 2026
zerosnacks
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added validation in config loading to reject
optimizer_runsvalues exceedingu32::MAX. The Solidity compiler expects this parameter as u32, and the doc comment at line 271 already documents this limit. Now the config fails early with a clear error instead of causing undefined behavior at compile time.