feat(cast): mine TIP20 virtual address master salt#14365
Merged
zerosnacks merged 6 commits intomasterfrom Apr 17, 2026
Merged
Conversation
0xrusowsky
requested review from
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse,
onbjerg,
stevencartavia and
zerosnacks
as code owners
mablr
reviewed
Apr 17, 2026
Comment on lines
+159
to
+161
| let salt_word = unsafe { | ||
| &mut *salt.0.as_mut_ptr().add(32 - usize::BITS as usize / 8).cast::<usize>() | ||
| }; |
Collaborator
There was a problem hiding this comment.
Can we get rid of this unsafe block by just reading/writing the last 8 bytes as a u64 via u64::from_le_bytes / to_le_bytes?
It's one extra copy per iteration, negligible versus the keccak cost I believe.
Contributor
Author
There was a problem hiding this comment.
i copied this from crates/cast/src/cmd/create2.rs, didn't think much about it and assumed it was optimal perf-wise
DaniPopes
previously approved these changes
Apr 17, 2026
mablr
previously approved these changes
Apr 17, 2026
mablr
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR adds
cast tip20 mine(alias:m) — a multi-threaded CPU miner for https://docs.tempo.xyz/protocol/tip1022 proof-of-work salts required to register a virtual master address on Tempo.PR Checklist