feat: make asm-keccak a default feature in all binaries#14389
Merged
Conversation
DaniPopes
requested review from
0xrusowsky,
figtracer,
grandizzy,
mablr,
mattsse,
onbjerg,
stevencartavia and
zerosnacks
as code owners
DaniPopes
force-pushed
the
dani/asm-keccak-default
branch
2 times, most recently
from
ee089c4 to
4d06664
Compare
Enable asm-keccak by default in forge, anvil, cast, and chisel, matching reth's approach. This ensures assembly-optimized keccak256 is always used in production builds without requiring explicit feature flags. Also forwards revm/asm-keccak where revm is a direct dependency (forge, anvil, cast) to ensure the EVM executor also uses the fast path. Removes the now-redundant asm-keccak from Makefile FEATURES and CI workflow feature lists.
DaniPopes
force-pushed
the
dani/asm-keccak-default
branch
from
4d06664 to
af0a6ca
Compare
mattsse
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
asm-keccaka default feature in all four binary crates (forge, anvil, cast, chisel), matching reth's approach where production binaries enable assembly-optimized keccak256 out-of-the-box.Also forwards
revm/asm-keccakwhere revm is a direct dependency (forge, anvil, cast) so the EVM executor also uses the fast path.Since
asm-keccakis now a default, it's removed from the explicit feature lists in the Makefile and CI workflows (release.yml,docker-publish.yml).