fix: accept 0x-prefixed value inputs#14406
Merged
zerosnacks merged 3 commits intofoundry-rs:masterfrom Apr 22, 2026
Merged
Conversation
figtracer
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
mablr,
mattsse,
onbjerg,
stevencartavia and
zerosnacks
as code owners
…pand tests Amp-Thread-ID: https://ampcode.com/threads/T-019db45a-2ee1-771d-8127-2052dc6df2a3 Co-authored-by: Amp <amp@ampcode.com>
zerosnacks
approved these changes
Apr 22, 2026
mablr
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14403.
Summary
Fix
parse_ether_valueandparse_ether_or_weito correctly handle0x-prefixed hex strings (e.g.--value 0x12).Problem
The previous code passed the full
0x-prefixed string toU256::from_str_radix(value, 16), which treats thexas an invalid hex digit.Fix
Use
U256::from_str(value)which natively handles the0x/0Xprefix — it strips the prefix and delegates tofrom_str_radixwith base 16 internally.Also adds
0Xprefix support and expands regression tests to cover hex, decimal, and ether-tagged values.