feat: log broken invariant as soon as it is found#14433
Merged
zerosnacks merged 3 commits intomasterfrom Apr 24, 2026
Merged
Conversation
stevencartavia
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse,
onbjerg and
zerosnacks
as code owners
grandizzy
requested changes
Apr 24, 2026
Collaborator
grandizzy
left a comment
grandizzy
left a comment
There was a problem hiding this comment.
looks good, ty, minor nit re payload to match proposed one
mablr
reviewed
Apr 24, 2026
Collaborator
mablr
left a comment
mablr
left a comment
There was a problem hiding this comment.
lgtm, just a minor concern
| #[derive(Debug, Default)] | ||
| struct InvariantFailureMetrics { | ||
| failures: u64, | ||
| unique_failures: HashSet<String>, |
Collaborator
There was a problem hiding this comment.
This seems to dedup by invariant name, what if two different have an invariant with the same name ?
Collaborator
There was a problem hiding this comment.
there can be invariants with same name but only in different contracts (an invariant is defined by solidity fn) but since we run each invariant campaign independently per (contract, function) pair, then they cannot collide
mablr
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
closes #13285
Solution
"failure"JSON event immediately when an invariant breaks, with timestamp, invariant name, target contract, and revert reasonfailuresandunique_failurescounters to periodic pulse metrics (will be non-zero once feat(invariant): assert all invariants oncontinuous_run#12587 lands)"event": "pulse"field to periodic metrics for uniform event dispatchPR Checklist