fix(tests): update gas report snapshot after gas params sync fix#14439
Merged
zerosnacks merged 2 commits intomasterfrom Apr 24, 2026
Merged
fix(tests): update gas report snapshot after gas params sync fix#14439zerosnacks merged 2 commits intomasterfrom
zerosnacks merged 2 commits intomasterfrom
Conversation
The deployment cost for CounterWithFallback changed from 132471 to 132459 after #14420 started properly syncing gas parameters when updating the executor spec via set_spec_id. Amp-Thread-ID: https://ampcode.com/threads/T-019dbea7-a331-7269-80a8-b935a7bdaa49 Co-authored-by: Amp <amp@ampcode.com>
zerosnacks
requested review from
0xrusowsky,
DaniPopes,
figtracer,
grandizzy,
mablr,
mattsse,
onbjerg and
stevencartavia
as code owners
mablr
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the
flaky_gas_report_fallback_with_calldatatest snapshot to reflect the new deployment cost after #14420.Closes #14435
Closes #14434
Details
#14420changedset_spec_idto also callset_spec_and_mainnet_gas_params, properly syncing gas parameters with the EVM spec. This changed the deployment cost ofCounterWithFallbackfrom132471→132459(delta of 12 gas).The old snapshot value was slightly incorrect because gas params weren't being synced when updating the executor spec.
CI failure: https://github.com/foundry-rs/foundry/actions/runs/24865370005/job/72800087298