fix: Presentation currency conversion in reports#27316
Merged
deepeshgarg007 merged 1 commit intofrappe:developfrom Sep 5, 2021
Merged
fix: Presentation currency conversion in reports#27316deepeshgarg007 merged 1 commit intofrappe:developfrom
deepeshgarg007 merged 1 commit intofrappe:developfrom
Conversation
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Sep 5, 2021
(cherry picked from commit ceaa804) # Conflicts: # erpnext/accounts/report/utils.py
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Sep 5, 2021
(cherry picked from commit ceaa804)
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As shown in the image above there could be cases where a single GL might have both Debit and Credit values
Currently, the function used to convert values to presentation currency assumed that one GL Entry will either have debit or credit value while led to wrong values in the reports when a presentation currency was selected