fix: document naming rule not working for subscription invoices#27386
Merged
nextchamp-saqib merged 1 commit intofrappe:developfrom Sep 8, 2021
Merged
Conversation
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Sep 8, 2021
frappe-pr-bot
pushed a commit
to frappe-pr-bot/erpnext
that referenced
this pull request
Sep 8, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document Naming Rule on Sales Invoice
Created a Subscription for the Company associated with that Company GSTIN
Now clicking on Fetch Subscription Updates on the Subscription document creates a Sales Invoice with default naming instead of following the Document Naming Rule.
This is because the Company GSTIN is set in the
validatemethod of Sales Invoice while the naming is set beforevalidate, hence while setting the name, the Company GSTIN condition isfalse