refactor: payment reconciliation tool (backport #27128)#46109
Closed
mergify[bot] wants to merge 1 commit intoversion-13-hotfixfrom
Closed
refactor: payment reconciliation tool (backport #27128)#46109mergify[bot] wants to merge 1 commit intoversion-13-hotfixfrom
mergify[bot] wants to merge 1 commit intoversion-13-hotfixfrom
Conversation
(cherry picked from commit 3e404f1) # Conflicts: # erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.js # erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.json # erpnext/accounts/doctype/payment_reconciliation/payment_reconciliation.py # erpnext/accounts/doctype/payment_reconciliation/test_payment_reconciliation.py # erpnext/accounts/doctype/payment_reconciliation_allocation/payment_reconciliation_allocation.json # erpnext/accounts/doctype/payment_reconciliation_allocation/payment_reconciliation_allocation.py # erpnext/accounts/utils.py # erpnext/controllers/accounts_controller.py
Contributor
Author
|
Cherry-pick of 3e404f1 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
The problem with existing tool is that a user has to manually select invoices to reconcile against payments and, only one invoice can be reconciled against particular payment at a time which makes it tedious for the cases where multiple invoices are to be reconciled against single payment or vice versa
E.g. A single payment against multiple invoices
Suppose there are 50 invoices, a user will have to select an invoice against the payment 50 times and, GL Entry of this payment also gets cancelled & submitted 50 times
Fix:
Using this refactored tool, a user will be able to select any invoice or payment to reconcile.
Once the unreconciled entries are fetched, a user can either select any particular entries or just click on Allocate button without selecting anything, Allocation table will be populated based on FIFO and/or selection, and then click on Reconcile button to reconcile all the allocated entries.
This is an automatic backport of pull request #27128 done by [Mergify](https://mergify.com).