feat: Validity dates in Tax Withholding Rates (backport #27258)#46124
Closed
mergify[bot] wants to merge 8 commits intoversion-13-hotfixfrom
Closed
feat: Validity dates in Tax Withholding Rates (backport #27258)#46124mergify[bot] wants to merge 8 commits intoversion-13-hotfixfrom
mergify[bot] wants to merge 8 commits intoversion-13-hotfixfrom
Conversation
(cherry picked from commit 5e10e10) # Conflicts: # erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py # erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py # erpnext/accounts/doctype/tax_withholding_rate/tax_withholding_rate.json # erpnext/patches.txt # erpnext/patches/v13_0/update_dates_in_tax_withholding_category.py
(cherry picked from commit d06221a) # Conflicts: # erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py
(cherry picked from commit b6d0b17) # Conflicts: # erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py # erpnext/patches/v13_0/update_dates_in_tax_withholding_category.py
(cherry picked from commit d5a736d)
(cherry picked from commit 092d41e) # Conflicts: # erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py
(cherry picked from commit 51d9572) # Conflicts: # erpnext/accounts/doctype/fiscal_year/fiscal_year_dashboard.py # erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py
(cherry picked from commit c33bbd4) # Conflicts: # erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py
(cherry picked from commit e7e2ce1) # Conflicts: # erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py # erpnext/patches/v13_0/update_dates_in_tax_withholding_category.py
Contributor
Author
|
Cherry-pick of 5e10e10 has failed: Cherry-pick of d06221a has failed: Cherry-pick of b6d0b17 has failed: Cherry-pick of 092d41e has failed: Cherry-pick of 51d9572 has failed: Cherry-pick of c33bbd4 has failed: Cherry-pick of e7e2ce1 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced fiscal year in tax withholding rates with from and to date and patched existing records by Fiscal Year Start and End Dates
The reason for replacing this will from and to date is some categories come into effect from the mid of the fiscal year and hence only the invoices made during that period should be considered for checking threshold and not the entire fiscal year
no-docsThis is an automatic backport of pull request #27258 done by Mergify.